Skip to content

Nightly failure fixes #1586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
award999 merged 22 commits into from
May 27, 2025
Merged

Nightly failure fixes #1586

award999 merged 22 commits into from
May 27, 2025

Conversation

@award999
Copy link
Contributor

@award999 award999 commented May 27, 2025

  • Also check "Thenable"'s for no floating promises
  • Make command callbacks explicitly async
  • Move some tests to unit level
  • Provide some arguments to context as stubbing seems flaky on Windows
  • Make sure debug extensions are activated before running tests

award999 added 21 commits May 26, 2025 10:24
@award999
Capture promise before running command
3a376cb 
It times out after long wait so thinking there may be a timing issue here
@award999
Try match expression in case it's a equality issue
1e43d0c
@award999
Try to do a better job of capturing further data after exit
f1f719a 
Inspiration from microsoft/vscode@9464b54
@award999
Debug logging
e8786f7
@award999
Also check no floating thenables
f51da57
@award999
Make command callbacks async
7d5feb2
@award999
Fix failing test
5b57c71
@award999
See if using correct WorkspaceContext instance
e08cd8a
@award999
More debug logging
ece6b22
@award999
Try to return instead of resolve
0524d5c
@award999
Specify expected arguments
4d90b48
@award999
Allow passing count as command parameter
b31ae8e
@award999
Fix failing test
48def33
@award999
Debug logging
94d353c
@award999
Run function directly
2f35de0
@award999
Make these unit tests
73b63a1 
Don't require activated extension to test these
@award999
Remove debug logging
0684d68
@award999
Make sure debugger extensions are activated
65932cd 
Only activate first time since never will deactivate
@award999
Only need one folder for this test
8460489
@award999
Remove more debug logging
2cf0f52
@award999
Move to unit level
9631ef1
@award999 award999 requested a review from adam-fowler as a code owner May 27, 2025 14:22
@award999 award999 added the full-test-run Perform a full test suite run. Apply this label before pushing up a PR or commit label May 27, 2025
@award999 award999 requested a review from 0xTim as a code owner May 27, 2025 14:22
@award999 award999 requested review from matthewbastien and plemarquand and removed request for 0xTim, adam-fowler, matthewbastien and plemarquand May 27, 2025 14:43
matthewbastien
matthewbastien approved these changes May 27, 2025
View reviewed changes
Copy link
Member

@matthewbastien matthewbastien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

rbenegal
rbenegal reviewed May 27, 2025
View reviewed changes
rbenegal
rbenegal approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@rbenegal rbenegal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@award999 award999 merged commit 3de9e1b into swiftlang:main May 27, 2025
18 of 19 checks passed
@award999 award999 deleted the nightly-failures branch May 27, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewbastien matthewbastien matthewbastien approved these changes

@rbenegal rbenegal rbenegal approved these changes

@plemarquand plemarquand Awaiting requested review from plemarquand

Assignees

No one assigned

Labels

full-test-run Perform a full test suite run. Apply this label before pushing up a PR or commit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@award999 @matthewbastien @rbenegal